[issue11466] getpass.getpass doesn't close tty file

[Éric Araujo]

Éric Araujo <merwok at netwok.org> added the comment:

> About security: i think that you, Éric, have referred to this
> when you've said "your patch is not uncontroversial".

No, I was only referring to the fact that one unrelated change was present in a patch while it was still being discussed in another issue (“This new patch (11466.2.patch) also includes the #11236 patch”).

> it would be easier if _raw_input() would take a terminal_setup=False argument
> and encapsulate echoing of a final newline

It’s a private function, it that makes the patch smaller let’s change it.  The current patch looks rather complicated just to close a file object.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue11466>
_______________________________________