[issue10966] eliminate use of ImportError implicitly representing SkipTest

Éric Araujo report at bugs.python.org
Thu Mar 24 22:27:37 CET 2011


Éric Araujo <merwok at netwok.org> added the comment:

I’m probably the one with the least regrtest knowledge among us, but I like the general idea of moving the compat info from one huge dict into the tests themselves.  It looks more readable and maintainable.

The new tests for test.support looks good.

I have a reputation to maintain, so here are some nits:
- “FS encoding” would be clearer as “filesystem encoding”.
- The argument names “required_on” and “optional” are not symmetrical.
- The indentation is hard to read here:

+pty = import_module('pty',
+            optional=['win32', 'os2emx', 'freebsd4', 'freebsd5', 'freebsd6',
+                        'freebsd7', 'freebsd8'])

----------
nosy: +eric.araujo

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue10966>
_______________________________________


More information about the Python-bugs-list mailing list