[issue11700] mailbox.py proxy updates

Steffen Daode Nurpmeso report at bugs.python.org
Tue Mar 29 21:11:06 CEST 2011


Steffen Daode Nurpmeso <sdaoden at googlemail.com> added the comment:

This new patch adheres your suggestion.
Now all implemented operations perform
a "file is open at all" check and raise
ValueError if not, which somewhat reflects
what i've seen when i was looking into fileio.c.

My questions:
- shouldn't _ProxyFile inherit from
  a real Python I/O class, for example IOBase?
  Like this it would stand in a line where it belongs.
  I could do that (not much missing for that).
- I have no idea of the test framework.  The last hour
  i tried to adjust test_mailbox.py a bit, but it's hard.
  It's not about design and it's not about algorithm.  Uff.
  I could nonetheless add some cases to yet existing
  test functions and change another one.  But this needs
  a real eye on it!
  (For example: is there a AssertNoRaises?)

----------
Added file: http://bugs.python.org/file21452/11700.2.diff

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue11700>
_______________________________________


More information about the Python-bugs-list mailing list