[issue5723] Incomplete json tests

Antoine Pitrou report at bugs.python.org
Thu May 12 13:31:54 CEST 2011


Antoine Pitrou <pitrou at free.fr> added the comment:

Comments:
- I don't like the fact that skip_unless_cjson() uses unittest internals. Why can't you write something like:
   skip_unless_cjson = skipUnless(...)

- instead of "self.mod", "self.json" would be nicer

- you could also export "self.loads", "self.dumps" for easier access

- you could also have two base classes exporting all this instead of repeating the attribute-setting for every test class

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue5723>
_______________________________________


More information about the Python-bugs-list mailing list