[issue12021] mmap.read requires an argument
Charles-François Natali
report at bugs.python.org
Mon May 30 20:02:05 CEST 2011
Charles-François Natali <neologix at free.fr> added the comment:
The patch looks good to me.
In your test, you don't explicitely close the mmap object: it's not a problem with CPython since it will get unmmapped, and the file descriptor - if it's a file-backed mapping - will get closed, as soon as it gets out of scope, but it would be cleaner to close it explicitely with something like self.addCleanup(m.close).
----------
nosy: +charles-francois.natali
stage: needs patch -> patch review
_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue12021>
_______________________________________
More information about the Python-bugs-list
mailing list