[issue12221] segfaults with unexpanded $Revision$ id's in release candidate tarballs

[Matthias Klose]

New submission from Matthias Klose <doko at debian.org>:

Modules/pyexpat.c (get_version_string) has:

static PyObject *
get_version_string(void)
{
    static char *rcsid = "$Revision$";
    char *rev = rcsid;
    int i = 0;

    while (!isdigit(Py_CHARMASK(*rev)))
        ++rev;

which segfaults, or has unexpected results. -O2 builds don't show the segfaults, but at least debug builds on sparc, ARM, powerpc, m68k.

>>> pyexpat.__version__
'0\x05'

seen with all the current release candidates for 2.7.2, 3.1.4 and 3.2.1
2.5.6 and 2.6.7 don't have this issue.

other occurrences:

./setup.py:__version__ = "$Revision$"
./Demo/scripts/newslist.py:# Newslist  $Revision$
./Demo/scripts/newslist.py:rcsrev = '$Revision$'
./configure.in:AC_REVISION($Revision$)
./Tools/webchecker/websucker.py:__version__ = "$Revision$"
./Tools/webchecker/webchecker.py:__version__ = "$Revision$"
./Tools/world/world:__version__ = '$Revision$'
./Parser/asdl_c.py:        # Value of version: "$Revision$"
./Parser/Python.asdl:module Python version "$Revision$"
./Modules/pyexpat.c:    static char *rcsid = "$Revision$";
./Lib/tkinter/__init__.py:__version__ = "$Revision$"
./Lib/pickle.py:__version__ = "$Revision$"       # Code version
./Lib/xml/parsers/expat.py:__version__ = '$Revision$'
./Lib/pydoc.py:__version__ = "$Revision$"
./Lib/tarfile.py:__version__ = "$Revision$"

----------
components: Build
messages: 137347
nosy: benjamin.peterson, doko, georg.brandl
priority: release blocker
severity: normal
status: open
title: segfaults with unexpanded $Revision$ id's in release candidate tarballs
versions: Python 2.7, Python 3.1, Python 3.2

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue12221>
_______________________________________