[issue13193] test_packaging and test_distutils failures
report at bugs.python.org
Sat Nov 12 15:42:47 CET 2011
Antoine Pitrou <pitrou at free.fr> added the comment:
> Antoine, I appreciate that you took time to fix this bug while I was
> without Internet and without Windows, but unfortunately I will have to
> backout your commit. Postel’s Law doesn’t win here: It is documented
> that the MANIFEST template only accepts /-delimited paths,
“Just like in the setup script, file and directory names in the manifest
template should always be slash-separated”
That's "should", not "must".
Also, I thought people did undocumented things with distutils, and we
had to support these undocumented uses?
> In the future, please feel free to add unittest.expectedFailure
> decorators to problematic tests when I’m too long to come up with a
> fix, so that other people can see when their commits add problems.
I don't see how adding "expected failures" solves anything. It's not
clear why this failure should have been expected, rather than a bug.
A "commit adding problem" should be fixed or reverted; marking some
failures expected is just dodging the issue.
Python tracker <report at bugs.python.org>
More information about the Python-bugs-list