[issue13045] socket.getsockopt may require custom buffer contents

Charles-François Natali report at bugs.python.org
Mon Oct 3 19:04:47 CEST 2011


Charles-François Natali <neologix at free.fr> added the comment:

Hello,

method:: socket.getsockopt(level, optname[, optarg])

The overloading of the third parameter is confusing: it can already be an integer value or a buffer size, I don't think that adding a third possibility is a good idea. It might be better to add another optional `buffer` argument (and ignore `buflen` if this argument is provided).

Also, it would be nice to have a corresponding unit test: since I doubt this buffer argument is supported by many Unices out there, you can probably reuse a subset of what ipset does (just take care and guard it by @support.requires_linux_version() if applicable).

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue13045>
_______________________________________


More information about the Python-bugs-list mailing list