[issue12837] Patch for issue #12810 removed a valid check on socket ancillary data

Brett Cannon report at bugs.python.org
Thu Sep 1 07:06:59 CEST 2011


Brett Cannon <brett at python.org> added the comment:

This is now generating a compiler warning under OS X because the older POSIX standard is followed where socklen_t can be unsigned.

Attached is a patch to cast msg_controllen to a size big enough to hold either signed 2**31-1 or unsigned 2**32-1 (i.e., long long) to silence the compiler warning. I would check the patch in myself but test_socket is failing under OS X right now so I can't verify I didn't do something extremely stupid with the cast somehow.

----------
nosy: +brett.cannon
resolution: fixed -> 
stage: committed/rejected -> commit review
status: closed -> open
Added file: http://bugs.python.org/file23080/socket_compiler_warning.diff

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue12837>
_______________________________________


More information about the Python-bugs-list mailing list