[issue14310] Socket duplication for windows
Antoine Pitrou
report at bugs.python.org
Fri Apr 6 14:08:27 CEST 2012
Antoine Pitrou <pitrou at free.fr> added the comment:
Comments about the patch:
- versionadded should be 3.3, not 3.4
- MultiprocessingFunc would deserve a meaningful, PEP8 name; it should also probably be a classmethod on TestSocketSharing
- please use PEP8 for comments (a space after the "#")
- it would be nice to have a test for the ValueError when passing a bytes object of the wrong size
- also, there should be a test that the "family", "type" and "proto" attributes are correctly set on the fromshare() result (perhaps "timeout" too)
----------
_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue14310>
_______________________________________
More information about the Python-bugs-list
mailing list