[issue12537] mailbox's _become_message is very fragile

R. David Murray report at bugs.python.org
Mon Apr 9 04:43:23 CEST 2012


R. David Murray <rdmurray at bitdance.com> added the comment:

David, thanks for your assistance.  I didn't wind up using your patch, but the work you did was valuable in preparing the patch I committed.

What I did was turn your 'detect the attributes' recipe into a unit test.  I then applied your patch, but it didn't quite work.  I eventually figured out that the fix I suggested wasn't quite right, that in fact the right place to delete the attributes is in _become_message.  So I moved the list of attributes you developed in your patch into class attributes, so that what the final patch does is to copy everything *except* the attributes you found.

So, a successful resolution, thank you.

----------
resolution:  -> fixed
stage:  -> committed/rejected
status: open -> closed
type:  -> behavior

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue12537>
_______________________________________


More information about the Python-bugs-list mailing list