[issue13033] Add shutil.chowntree

Éric Araujo report at bugs.python.org
Fri Jan 6 17:42:42 CET 2012


Éric Araujo <merwok at netwok.org> added the comment:

Thanks for the patch.  Before you do any more work, do other core developers agree that this function is a good addition or is it obsoleted by the generic improved-walk-with-callback that Nick is working on?

Doc/library/shutil.rst:

I don’t think the note directives are needed.  The doc is not big, I assume people will read all of it and see the caveats.  (I’ll also want to group some small paragraphs.)

Lib/shutil.py:

+def chowntree(path, user=None, group=None, followlinks=False):
+ [...]
+    The dictionary _modified_items, will keep track of the old ownership details,
What _modified_items dictionary?

Apart from a few stylistic violations which can be fixed by the committer, the function looks good.

Lib/test/test_shutil.py:

Looks good and needs more tests.  Currently it only calls chowntree on a directory without children, so it does not test that the chown is indeed recursive.

----------
nosy: +giampaolo.rodola, haypo, ncoghlan, pitrou

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue13033>
_______________________________________


More information about the Python-bugs-list mailing list