[issue13963] dev guide has no mention of mechanics of patch review

[Dave Malcolm]

Dave Malcolm <dmalcolm at redhat.com> added the comment:

Some notes from discussion with MvL at PyCon sprint:

The ideal is that:
  - for any patch attached to an issue: the patch is uploaded to a Rietveld instance colocated in the same db as Roundup (bugs.python.org)
    - if it works, than a "review" link is visible next to the patch, taking you to a patch review UI: unfortunately, it takes you to the most recent patch on the issue, rather than the patch you click on
    - unfortunately there are a few ways for the patch upload to fail, and if this happens, then currently there is no visible indication within Roundup.  If this happens, then patch review will need to be done within Roundup itself (i.e. the comment form or via email)
  - how can it fail: the importer needs to determine what the baseline to which the patch is to be applied.  It can figure this out for a "hg diff" (assuming that the baseline revision is known to hg.python.org/cpython), but not for git-style diffs (unless you do it on the current head of "default")
  - in theory the nosy list of a bug within Roundup is synchronized with that of the patch within Rietveld.  Unfortunately there is currently at least one bug with this (e.g. dmalcolm isnt on the nosy of http://bugs.python.org/review/13703/show despite being on the nosy of http://bugs.python.org/issue13703): FIXME: do we have a metabug about this?
See:
  http://psf.upfronthosting.co.za/roundup/meta/issue394
  http://psf.upfronthosting.co.za/roundup/meta/issue439

Some code links:
  http://svn.python.org/projects/tracker/instances/python-dev/rietveld/
  http://svn.python.org/projects/tracker/instances/python-dev/extensions/create_patch.py

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue13963>
_______________________________________