[issue14371] Add support for bzip2 compression to the zipfile module
Serhiy Storchaka
report at bugs.python.org
Fri Mar 23 11:40:09 CET 2012
Serhiy Storchaka <storchaka at gmail.com> added the comment:
> The existing code uses the b"".join() idiom for linear-
> time concatenation, but the patch replaces it with a version that does
> "buf += data" after each read.
You made a mess. The existing code uses ``buf += data``, but I allowed myself
to replace it with the ``b"".join()`` idiom. The bzip2 codec has to deal with
large pieces of data, now this may be important. In read1 still used ``buf +=
data``, but not in loop, there is a concatenation of the only two pieces.
> "The zip format specification has included support for bzip2 compression
Thank you. Can you offer the variant with including both bzip2 and lzma
(supported since 2006)? I put him in the upcoming patch that adds support for
lzma compression to the zipfile module.
----------
_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue14371>
_______________________________________
More information about the Python-bugs-list
mailing list