[issue14818] C implementation of ElementTree: Some functions should support keyword arguments

[Eli Bendersky]

Eli Bendersky <eliben at gmail.com> added the comment:

Ezio,

Your patch looks good, with these notes:

* When raising TypeError in the Python constructor, say that 'attrib' must be a dict, otherwise it's not clear *what* must be a dict.
* The 'attrib' keyword handling has to be added to SubElement too, as Markus said. I guess it would make sense to move it into some helper function to avoid duplication.
* The new keyword arguments have to be documented in the ReST docs of ET, since they haven't been documented until now

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue14818>
_______________________________________