[issue16296] Patch to fix building on Win32/64 under VS 2010

[Silverback Networks]

New submission from Silverback Networks:

Once I got my broken environment fixed, this was the only thing that didn't work. The bug is that VS 2010 no longer creates a manifest by default, despite the documentation, and there are confirmation posts around the internet. /Manifest has to be forced starting with VS 2010. Here is a patch to fix that:


--- Lib/distutils/msvc9compiler.py    2011-08-14 11:17:42.000000000 -0700
+++ Lib/distutils/msvc9compiler.py    2012-10-21 10:38:42.257682200 -0700
@@ -411,10 +411,16 @@
                                           '/Z7', '/D_DEBUG']

         self.ldflags_shared = ['/DLL', '/nologo', '/INCREMENTAL:NO']
+        if self.__version >= 10:
+            self.ldflags_shared = ['/DLL', '/nologo', '/INCREMENTAL:NO', '/Manifest']
         if self.__version >= 7:
             self.ldflags_shared_debug = [
                 '/DLL', '/nologo', '/INCREMENTAL:no', '/DEBUG', '/pdb:None'
                 ]
+            if self.__version >= 10:
+                self.ldflags_shared = [
+                '/DLL', '/nologo', '/INCREMENTAL:NO', '/DEBUG', '/pdb:None', '/Manifest'
+                ]
         self.ldflags_static = [ '/nologo']

         self.initialized = True

----------
components: Build
messages: 173464
nosy: silverbacknet
priority: normal
severity: normal
status: open
title: Patch to fix building on Win32/64 under VS 2010
type: compile error
versions: Python 3.1, Python 3.2, Python 3.3, Python 3.4

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue16296>
_______________________________________