[issue12837] Patch for issue #12810 removed a valid check on socket ancillary data

[Brett Cannon]

Brett Cannon added the comment:

First, sorry about the noise in the patch.

Second, the patch should contain just three pragma lines:

  #pragma clang diagnostic push
  #pragma clang diagnostic ignored "-Wtautological-compare"
  ...
  #pragma clang diagnostic pop

Now I don't think that's unreadable at all, nor runs any risk of breaking anything. And since the majority of Clang users are probably on OS X that would suggest that the suppression of the warning will only affect those where the warning is superfluous and won't lead to unneeded suppressions (if people are really worried about unneeded suppressions I can try to break the 'if' guard up to only suppress on the one part).

I just don't want to perpetually be ignoring a single warning in the code. That leads to me ignoring any warnings that come during compilation, which is unfortunate as some warnings are actually useful and should be rectified.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue12837>
_______________________________________