[issue18007] CookieJar expects request objects with origin_req_host attribute instead of method

[Simon Nicolussi]

New submission from Simon Nicolussi:

A fix for a DeprecationWarning (#17678) had the unfortunate side effect of changing the expected interface of the request object higher up in the call stack.

For example, the documentation for CookieJar.add_cookie_header(request) states that the request object must support the methods get_full_url(), get_host(), get_type(), unverifiable(), get_origin_req_host(), has_header(), get_header(), header_items(), and add_unredirected_header(). The patch for #17678, however, changes the requirement for a get_origin_req_host() method to an origin_req_host attribute.

This breaks at least one notable third-party library (Kenneth Reitz' Requests).

----------
assignee: docs at python
components: Documentation, Library (Lib)
messages: 189523
nosy: docs at python, orsenthil, sinic
priority: normal
severity: normal
status: open
title: CookieJar expects request objects with origin_req_host attribute instead of method
type: behavior
versions: Python 3.3

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue18007>
_______________________________________