[issue18809] Expose mtime check in importlib.machinery.FileFinder

[Brett Cannon]

Brett Cannon added the comment:

So I tried extracting out the check by implementing a path_mtime() method on FileFinder, but then I realized it would simply be easier to abstract out _os.stat() to _path_stat() and let people cache stat calls at the global level, which would have a side-effect of never refreshing the path cache. Otherwise all of the other experiments I tried with minimizing stat calls didn't buy me much according to the benchmarks.

I have also attached a patch which abstracts all file system code that passed through _os into a class. It didn't buy me much plus added a little overhead thanks to the extra abstraction, so I did not bother to commit it.

----------
keywords: +patch
resolution:  -> rejected
status: open -> closed
Added file: http://bugs.python.org/file32452/OO_os.diff

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue18809>
_______________________________________