[issue19739] Legit compiler warnings in new pickle code on 32-bit Windows

[Tim Peters]

New submission from Tim Peters:

1>..\Modules\_pickle.c(710): warning C4293: '>>' : shift count negative or too big, undefined behavior
1>..\Modules\_pickle.c(711): warning C4293: '>>' : shift count negative or too big, undefined behavior
1>..\Modules\_pickle.c(712): warning C4293: '>>' : shift count negative or too big, undefined behavior
1>..\Modules\_pickle.c(713): warning C4293: '>>' : shift count negative or too big, undefined behavior
1>..\Modules\_pickle.c(1158): warning C4018: '<' : signed/unsigned mismatch

The first 4 should be easy to fix by using a SIZEOF_SIZE_T >= 8 #ifdef test.  The last is on:

        if (frame_len < n) { ... raise an exception ...

where `frame_len` is size_t and `n` is Py_ssize_t.

----------
assignee: alexandre.vassalotti
messages: 204084
nosy: alexandre.vassalotti, pitrou, tim.peters
priority: normal
severity: normal
status: open
title: Legit compiler warnings in new pickle code on 32-bit Windows
versions: Python 3.4

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue19739>
_______________________________________