[issue19788] Always run kill_python(_d).exe when (re-)building on Windows

[Zachary Ware]

New submission from Zachary Ware:

The attached patch turns running kill_python(_d).exe into a PreBuildEvent in pythoncore.vcxproj.  This should guarantee that kill_python(_d).exe is always run to guarantee no zombie pythons in the background can prevent overwriting the Python dll.  The pythoncore project already depends on the kill_python project, so kill_python should always be built and ready before this PreBuildEvent fires.  The patch also removes the separate building and running of kill_python_d.exe from the buildbot build scripts, since it should be unnecessary with the patch to pythoncore.vcxproj.

Tim Peters, this patch was partly inspired by your issues in #19779; I suspect that perhaps your rebuild didn't take due to the segfaulted interpreter still hanging around in the background since the same thing happened to me doing a rebuild from the command line.  Would you mind testing this patch to see if it would have helped in your case?  Steps to test should be something like:

- update to e39db21df580
- build, run test_concurrent_futures (expect segfault)
- update to default
- rebuild, run test_concurrent_futures (expect build error and segfault again)
- apply patch
- rebuild, run test_concurrent_futures (expect success (or usual result))

----------
components: Build, Windows
files: kill_python_prebuild.diff
keywords: patch
messages: 204448
nosy: brian.curtin, tim.golden, tim.peters, zach.ware
priority: normal
severity: normal
stage: patch review
status: open
title: Always run kill_python(_d).exe when (re-)building on Windows
type: enhancement
versions: Python 3.3, Python 3.4
Added file: http://bugs.python.org/file32848/kill_python_prebuild.diff

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue19788>
_______________________________________