[issue20679] 3.4 cherry-pick: 587fd4b91120 improve Enum subclass behavior

Serhiy Storchaka report at bugs.python.org
Thu Feb 20 08:32:56 CET 2014


Serhiy Storchaka added the comment:

Besides insignificant style nitpick ("if classdict.get('__reduce_ex__') is None" can be written as "if '__reduce_ex__' not in classdict") the patch LGTM at first glance. I'm not very familiar with Enum's complicated machinery and don't sure that no bugs left here (I'm not sure that we should sabotage pickling at all, other types have no such paranoid guard), but at least I'm sure this patch doesn't make things worse. On other hand, this doesn't look as critical bugfix and may be can wait for 3.4.1. Ethan's, Eli's and Barry's opinions have more weight in this matter.

----------
nosy: +barry, eli.bendersky, serhiy.storchaka

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue20679>
_______________________________________


More information about the Python-bugs-list mailing list