[issue20707] 3.4 cherry-pick: bf413a97f1a9 fix conflicting hypot definition with VS 2010

[Zachary Ware]

New submission from Zachary Ware:

PC/pyconfig.h does "#define hypot _hypot", but VS 2010 and above already define a hypot function (implemented by _hypot), which results in a warning if you have warning 4211 enabled (which warning level 4 does) or a recursive definition which results in a crash at runtime, depending on how you use Python.h.  Python itself doesn't suffer from the runtime crash, but Blender does because of Python.

bf413a97f1a9 fixes it by guarding the #define with #if _MSC_VER < 1600.

This one is kind of borderline for RC phase in my mind, so I leave it up to you to decide, Larry.  It is a serious issue for at least Blender and one other extension author.  On the other hand, this issue has been around since 3.3.0 (the first VS 2010-supporting release) and was only reported this January.

----------
assignee: larry
components: Build, Windows
messages: 211756
nosy: larry, zach.ware
priority: release blocker
severity: normal
status: open
title: 3.4 cherry-pick: bf413a97f1a9 fix conflicting hypot definition with VS 2010
type: behavior
versions: Python 3.4

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue20707>
_______________________________________