[issue18643] add a fallback socketpair() implementation in test.support

STINNER Victor report at bugs.python.org
Thu Jul 24 10:49:10 CEST 2014


STINNER Victor added the comment:

2014-07-24 10:11 GMT+02:00 Charles-François Natali <report at bugs.python.org>:
>> Please also fix socketpair() in asyncio to add the while/drop unknown
>> connection (well, the function in socket.py and windows_utils.py must
>> be the same).
>
> That's a separate issue.

Ok.

>> Oh, and you forgot to modify the documentation to update
>> "Availability". Please add a ".. versionchanged:: 3.5" mentionning
>> that the function is now also available on Windows.
>
> Did you look at the patch?
>
> 363 .. versionchanged:: 3.5
> 364 Windows support added

Ok, I missed this part.

In this case, socketpair-4.diff looks good to me. You can commit your
patch in Python 3.5.

I will open another issue to synchronize asyncio, maybe fix accept()
to check the address and drop the "if proto != 0:" test.

----------

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue18643>
_______________________________________


More information about the Python-bugs-list mailing list