[issue21679] Prevent extraneous fstat during open()
Bohuslav "Slavek" Kabrda
report at bugs.python.org
Mon Jun 9 10:12:08 CEST 2014
Bohuslav "Slavek" Kabrda added the comment:
Thanks a lot for the code review! I'm attaching a revised version of the patch. Fixes I made:
- added check whether PyLong_AsLong returned an error
- removed "ADD_INTERNED(_blksize)" and "PyObject *_PyIO_str__blksize;" - I noticed that these are only necessary when exported by _iomodule.h, which isn't needed for _blksize ATM
- moved blksize to a place of fileio structure where it won't create unnecessary padding
I hope attaching the version 2 of the patch here is ok, if I should have attached it in the code review tool somehow, please let me know.
----------
Added file: http://bugs.python.org/file35540/python3-remove-extraneous-fstat-on-file-open-v2.patch
_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue21679>
_______________________________________
More information about the Python-bugs-list
mailing list