Claudiu Popa added the comment: There's a small typo in your patch, strign instead of string. Otherwise, looks good to me. ---------- stage: patch review -> commit review _______________________________________ Python tracker <report at bugs.python.org> <http://bugs.python.org/issue12916> _______________________________________