[issue21467] IDLE icon not included in Windows installer

[Terry J. Reedy]

Terry J. Reedy added the comment:

Steve, I am *really* glad you caught this. We obviously need a new test somewhere that would have caught this before the release. How is the installer tested now? Is it run and the installed python tested with the test suite? If so, a new idle test that runs idlelib/idle.(bat, py, pyw) with subprocess, detects startup errors, and cleanly shuts down the subprocces, would cover the installer.

3.4 is not directly affected because 3.4 Tools/msi/msi.py does not include the patched section
         if dir=="Icons":
             lib.glob("*.gif")
+            lib.glob("*.ico")
             lib.add_file("idle.icns")
and .gif and .icns are not in the file. Perhaps the change matches a change in the build process.

However, new tests should go on all versions.

----------
stage:  -> test needed

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue21467>
_______________________________________