[issue21520] Erroneous zipfile test failure if the string 'bad' appears in pwd

[Larry Hastings]

New submission from Larry Hastings:

If you extract current Python (3.4 or trunk) into a directory, and anywhere in the name of the directory is the string "bad", such as

/tmp/badtest
/home/baddison/src/python

then test_write_filtered_python_package() in Lib/test/test_zipfile.py will fail.  The reason is, the third subtest uses a "filterfunc" to ignore certain files, and its test to ignore files is effectively

   "bad" in fn

("fn" is an ill-conceived abbreviation for "filename")

This is overbroad.  Changing it to

   "Lib/test/bad" in fn

prevents this error.

I'm creating this issue just to remind myself to fix it.  3.4.1 is tagged and I didn't want to re-cut the release, but I didn't feel like pushing it while 3.4.1 hadn't landed in trunk yet.

----------
assignee: larry
components: Tests
messages: 218735
nosy: larry
priority: normal
severity: normal
stage: needs patch
status: open
title: Erroneous zipfile test failure if the string 'bad' appears in pwd
type: behavior
versions: Python 3.4, Python 3.5

_______________________________________
Python tracker <report at bugs.python.org>
<http://bugs.python.org/issue21520>
_______________________________________