[issue42069] Make filecmp more pythonic
Raymond Hettinger
report at bugs.python.org
Sun Oct 18 13:38:23 EDT 2020
Raymond Hettinger <raymond.hettinger at gmail.com> added the comment:
In general, we don't accept patches like this:
* It risks breaks (in fact the tests are failing.
* We're not apply Black's quoting preferences to existing files.
* We're not yet adding type annotations through out.
* The PR introduces multiple new dependencies on other modules.
This tends to slow down load time and complicate maintenance.
* There are subtle changes to the logic and API because
of the dataclasses, cached_property, and lru_cache.
* We want to avoid code churn because it reduces stability
and because it complicates maintenance (making it harder to
apply fixes across versions).
Thank you for the suggestion, but we'll decline.
----------
nosy: +rhettinger
resolution: -> rejected
stage: patch review -> resolved
status: open -> closed
_______________________________________
Python tracker <report at bugs.python.org>
<https://bugs.python.org/issue42069>
_______________________________________
More information about the Python-bugs-list
mailing list