[Python-checkins] CVS: python/dist/src/Python ceval.c,2.165,2.166

Guido van Rossum guido@CNRI.Reston.VA.US
Wed, 12 Jan 2000 17:57:55 -0500

> For the PyRun_File case, you've introduced a Py_DECREF() that wasn't there
> before. Was that intended?

Yes.  It was a leak.  It didn't really leak, because it always
returned None, but it caused the reference count for None to increase
ad infinitum.

> Also note that PyString_AS_STRING() and PyString_GETSIZE could be used
> since the object must be a string.

I don't care about using those macros except in performance critical
contexts, which this can hardly be (relatively speaking, the parsing
takes forever).

--Guido van Rossum (home page: http://www.python.org/~guido/)