[Python-checkins] CVS: distutils/distutils/command build_ext.py,1.33,1.34

[Greg Ward]

Update of /projects/cvsroot/distutils/distutils/command
In directory newcnri:/tmp/cvs-serv10408/command

Modified Files:
	build_ext.py 
Log Message:
Added comment about the MSVC-specific kludge.

Index: build_ext.py
===================================================================
RCS file: /projects/cvsroot/distutils/distutils/command/build_ext.py,v
retrieving revision 1.33
retrieving revision 1.34
diff -C2 -r1.33 -r1.34
*** build_ext.py	2000/05/06 13:12:59	1.33
--- build_ext.py	2000/05/09 01:50:41	1.34
***************
*** 7,11 ****
  # created 1999/08/09, Greg Ward
  
! __revision__ = "$Id: build_ext.py,v 1.33 2000/05/06 13:12:59 gward Exp $"
  
  import sys, os, string, re
--- 7,11 ----
  # created 1999/08/09, Greg Ward
  
! __revision__ = "$Id: build_ext.py,v 1.34 2000/05/09 01:50:41 gward Exp $"
  
  import sys, os, string, re
***************
*** 309,312 ****
--- 309,322 ----
              extra_args = build_info.get ('extra_link_args') or []
  
+             # XXX this is a kludge!  Knowledge of specific compilers or
+             # platforms really doesn't belong here; in an ideal world, the
+             # CCompiler interface would provide access to everything in a
+             # compiler/linker system needs to build Python extensions, and
+             # we would just do everything nicely and cleanly through that
+             # interface.  However, this is a not an ideal world and the
+             # CCompiler interface doesn't handle absolutely everything.
+             # Thus, kludges like this slip in occasionally.  (This is no
+             # excuse for committing more platform- and compiler-specific
+             # kludges; they are to be avoided if possible!)
              if self.compiler.compiler_type == 'msvc':
                  def_file = build_info.get ('def_file')