[Python-checkins] CVS: python/nondist/peps pep-0200.txt,1.36,1.37
Tim Peters
python-dev@python.org
Fri, 1 Sep 2000 00:05:02 -0700
Update of /cvsroot/python/python/nondist/peps
In directory slayer.i.sourceforge.net:/tmp/cvs-serv24827
Modified Files:
pep-0200.txt
Log Message:
Record that test_popen2 on Windows failed again, and why.
Removed the line about "Windows threads problems" because I believe
the test_popen2 failure is what that was talking about.
Index: pep-0200.txt
===================================================================
RCS file: /cvsroot/python/python/nondist/peps/pep-0200.txt,v
retrieving revision 1.36
retrieving revision 1.37
diff -C2 -r1.36 -r1.37
*** pep-0200.txt 2000/09/01 03:06:39 1.36
--- pep-0200.txt 2000/09/01 07:04:59 1.37
***************
*** 96,100 ****
Add popen2 support for Linux -- Fred Drake
- There are some threads problems on windows...
Deal with buffering problem with SocketServer -- GvR
--- 96,99 ----
***************
*** 176,179 ****
--- 175,187 ----
test_popen2 Win32 26-Jul-2000
+ [31-Aug-2000 tim
+ This died again, but for an entirely different reason: it uses a
+ dict to map file pointers to process handles, and calls a dict
+ access function during popen.close(). But .close releases threads,
+ which left the internal popen code accessing the dict without a
+ valid thread state. The dict implementation changed so that's no
+ longer accepted. Fixed by creating a temporary thread state in the
+ guts of popen's close routine, and grabbing the global lock with
+ it for the duration]
[20-Aug-2000 tim
changed the popen2.py _test function to use the "more" cmd