[Python-checkins] CVS: python/dist/src/Include unicodeobject.h,2.19,2.20

M.-A. Lemburg lemburg@users.sourceforge.net
Mon, 23 Apr 2001 07:44:23 -0700


Update of /cvsroot/python/python/dist/src/Include
In directory usw-pr-cvs1:/tmp/cvs-serv1593/Include

Modified Files:
	unicodeobject.h 
Log Message:
This patch originated from an idea by Martin v. Loewis who submitted a
patch for sharing single character Unicode objects. 

Martin's patch had to be reworked in a number of ways to take Unicode
resizing into consideration as well. Here's what the updated patch
implements:

* Single character Unicode strings in the Latin-1 range are shared
  (not only ASCII chars as in Martin's original patch).

* The ASCII and Latin-1 codecs make use of this optimization,
  providing a noticable speedup for single character strings. Most
  Unicode methods can use the optimization as well (by virtue
  of using PyUnicode_FromUnicode()).

* Some code cleanup was done (replacing memcpy with Py_UNICODE_COPY)

* The PyUnicode_Resize() can now also handle the case of resizing
  unicode_empty which previously resulted in an error.

* Modified the internal API _PyUnicode_Resize() and
  the public PyUnicode_Resize() API to handle references to
  shared objects correctly. The _PyUnicode_Resize() signature
  changed due to this.

* Callers of PyUnicode_FromUnicode() may now only modify the Unicode
  object contents of the returned object in case they called the API
  with NULL as content template.

Note that even though this patch passes the regression tests, there
may still be subtle bugs in the sharing code.



Index: unicodeobject.h
===================================================================
RCS file: /cvsroot/python/python/dist/src/Include/unicodeobject.h,v
retrieving revision 2.19
retrieving revision 2.20
diff -C2 -r2.19 -r2.20
*** unicodeobject.h	2000/08/11 11:43:10	2.19
--- unicodeobject.h	2001/04/23 14:44:21	2.20
***************
*** 240,245 ****
  
  /* Create a Unicode Object from the Py_UNICODE buffer u of the given
!    size. u may be NULL which causes the contents to be undefined. It
!    is the user's responsibility to fill in the needed data.
  
     The buffer is copied into the new object. */
--- 240,249 ----
  
  /* Create a Unicode Object from the Py_UNICODE buffer u of the given
!    size. 
! 
!    u may be NULL which causes the contents to be undefined. It is the
!    user's responsibility to fill in the needed data afterwards. Note
!    that modifying the Unicode object contents after construction is
!    only allowed if u was set to NULL.
  
     The buffer is copied into the new object. */