[Python-checkins] CVS: python/dist/src/Lib/xml/sax saxutils.py,1.15,1.16

[Fred L. Drake]

Update of /cvsroot/python/python/dist/src/Lib/xml/sax
In directory usw-pr-cvs1:/tmp/cvs-serv6947/xml/sax

Modified Files:
	saxutils.py 
Log Message:

Make sure XMLGenerator uses quoteattr() instead of escape() to quote
attribute values.  Just using escape() can (and always has) led to broken
XML being generated.  This makes sure it always produces the right thing.

This actually closes SF bug #440351.


Index: saxutils.py
===================================================================
RCS file: /cvsroot/python/python/dist/src/Lib/xml/sax/saxutils.py,v
retrieving revision 1.15
retrieving revision 1.16
diff -C2 -d -r1.15 -r1.16
*** saxutils.py	2001/07/19 16:10:15	1.15
--- saxutils.py	2001/08/07 19:14:46	1.16
***************
*** 81,85 ****
          self._out.write('<' + name)
          for (name, value) in attrs.items():
!             self._out.write(' %s="%s"' % (name, escape(value)))
          self._out.write('>')
  
--- 81,85 ----
          self._out.write('<' + name)
          for (name, value) in attrs.items():
!             self._out.write(' %s=%s' % (name, quoteattr(value)))
          self._out.write('>')
  
***************
*** 102,106 ****
          for (name, value) in attrs.items():
              name = self._current_context[name[0]] + ":" + name[1]
!             self._out.write(' %s="%s"' % (name, escape(value)))
          self._out.write('>')
  
--- 102,106 ----
          for (name, value) in attrs.items():
              name = self._current_context[name[0]] + ":" + name[1]
!             self._out.write(' %s=%s' % (name, quoteattr(value)))
          self._out.write('>')