[Python-checkins] CVS: python/dist/src/Modules posixmodule.c,2.223,2.224

Tim Peters tim.one@comcast.net
Tue, 05 Mar 2002 17:52:55 -0500

> Modified Files:
> 	posixmodule.c
> Log Message:
> Python no longer compiled on Windows, due to #include file confusion
> ...

[Andrew MacIntyre]
> I presume this was as a result of my large commit :-(  Sorry.

Probably, but don't worry about it.  Historically, the Windows build breaks
about once per week, and it's my stated policy that I'd much rather fix it
after the fact then pee away time applying patches in advance.  One reason
for that is, if I wait until after the build is broken, it's much easier to
shame the committer into making fixes an urgent priority <wink -- but, in
the end, that helps move things along>.

> It has occurred to me that posixmodule.c is nearly a candidate for the
> approach applied to threads and dynamic loading....

I don't expect it would really help, for much the same reason
thread_pthread.h alone has a mass of inscructable #ifdefs at its start, yet
keeps breaking on pthreads platforms anyway:  outside the 300-line
preprocessor maze at the start of posixmodule.c, most of the #ifdef hair in
the remaining 6400 lines has to do with untangling Unix variations.