[Python-checkins] python/dist/src/Modules posixmodule.c, 2.318, 2.319

Neal Norwitz neal at metaslash.com
Tue Jun 8 21:48:41 EDT 2004


On Tue, Jun 08, 2004 at 12:36:07PM +0200, Thomas Heller wrote:
> nnorwitz at users.sourceforge.net writes:
> 
> > Update of /cvsroot/python/python/dist/src/Modules
> > In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv16270/Modules
> >
> > Modified Files:
> > 	posixmodule.c 
> > Log Message:
> > Plug a few memory leaks in utime().  path is allocated from within 
> > PyArg_ParseTuple() since the format is "et"  This change should
> > be reviewed carefully.
> 
> I believe 'path' must be set to NULL at the start of the posix_utime
> function - I had a crash in a debug build on windows when running
> lib\test\test_unicode_file.py.

Yes, you are correct.  I checked in a fix.  path should not be used if
have_unicode_filename is set.  So I removed an unnecessary free too.

Let me know if you have any more problems.

Neal




More information about the Python-checkins mailing list