[Python-checkins] r43554 - python/trunk/Lib/urllib2.py

Georg Brandl g.brandl at gmx.net
Sun Apr 2 23:13:23 CEST 2006


Neal Norwitz wrote:
> On 4/2/06, georg.brandl <python-checkins at python.org> wrote:
>> Author: georg.brandl
>> Date: Sun Apr  2 22:48:11 2006
>> New Revision: 43554
>>
>> Modified:
>>    python/trunk/Lib/urllib2.py
>> Log:
>> Patch #1463012: remove not working undocumented classes from urllib2
>>
>>
>>
>> Modified: python/trunk/Lib/urllib2.py
>> ==============================================================================
>> --- python/trunk/Lib/urllib2.py (original)
>> +++ python/trunk/Lib/urllib2.py Sun Apr  2 22:48:11 2006
>> @@ -111,8 +108,7 @@
>>  except ImportError:
>>      from StringIO import StringIO
>>
>> -# not sure how many of these need to be gotten rid of
>> -from urllib import (unwrap, unquote, splittype, splithost, quote,
>> +from urllib import (unwrap, unquote, splittype, splithost,
> 
> I'm curious why quote was removed?  ISTM that people might be relying
> on urllib2.quote, even if by mistake (ie, they meant urllib.quote). 
> Although, Google didn't seem to find anything when I searched for
> urllib2.quote.

Granted, that would be gratuitous breakage. Readded in rev. 43556.

Georg



More information about the Python-checkins mailing list