[Python-checkins] r43586 - python/trunk/Modules/posixmodule.c

Neal Norwitz nnorwitz at gmail.com
Tue Apr 4 08:01:14 CEST 2006


On 4/3/06, "Martin v. Löwis" <martin at v.loewis.de> wrote:
> Neal Norwitz wrote:
> > Unless I'm reading this patch wrong, it looks like it will crash if
> > only a single parameter is passed in.  With a single argument,
> > operation is NULL and strlen(NULL) go boom.
>
> This is true; I later corrected it.

Very good, thank you.  I missed it when going through mail.  The code
looks good now.

> > I think this patch should be reverted, unless a test case is added and
> > the coded corrected.
>
> So what should the test case do? There currently aren't any test cases
> for startfile at all; "just" extending them to Unicode strings isn't
> possible.

I'm not sure of the exact syntax on windows, but how about something like:

  command.exe echo "string"

Where string can be unicode?  I'm not sure of all the variations.  How
about if command.exe is unicode?  Something like that seems relatively
easy and should catch most shallow errors.  Is that or something
similar doable?

n


More information about the Python-checkins mailing list