[Python-checkins] r50969 - in python/trunk: Include/pyerrors.h Misc/NEWS Modules/_struct.c Python/errors.c

[Neal Norwitz]

On 8/4/06, M.-A. Lemburg <mal at egenix.com> wrote:
> >
> > This change removed (on Windows) the PyErr_Warn *exported* function from
> > the python25.dll.  As a result, extensions compiled with earlier beta versions
> > of python 2.5 cannot be loaded any more; for example the win32com extensions
> > from Mark Hammond - but of course any other extensions that use this function.
> >
> > Btw: Shouldn't the PYTHON_API_VERSION (or how it's called) have also been changed?
> >
> > I'm unsure what to do:
> > - Implement PyErr_Warn as a function again (this was also done with other functions,
> >   see also #1465834).  Would this require another beta ;-)?
> > - Leave it as it is, and require that extensions needs to be rebuilt with 2.5b3
> >   (plus change the PYTHON_API_VERSION, ...)
> >
> > Anyway, it seems to me that *some* policy regarding changes to exported functions
> > should be established.
>
> In the past we've always kept a stub function around that
> was exported when converting a function to a macro.
>
> I guess this ought to happen in this case as well.

That was my intent.  I thought I left it in the C file so it would be
in a library, but any newly compiled code would use the new API.

Thomas if you can work up a patch, that would be great.  I will try to
take a look at it later.

n