[Python-checkins] r46894 - in python/trunk: Modules/timemodule.c Objects/exceptions.c Objects/fileobject.c

[Kristján V. Jónsson]

Interesting problem.
(Yes, I subscribe to python-chekins but it is hard to weed out the chaff there)

Is this compiler possibly an interrim soulution before VC8 came out?  Strange that it should call itself version 14.

Maybe we should bracket this with a _VC8 macro that is only defined
By the PCBuild8 directory?

I will fix this when I get to the office on Monday.
Kristján

-----Original Message-----
From: Tim Peters [mailto:tim.peters at gmail.com] 
Sent: 30. júní 2006 18:38
To: Kristján V. Jónsson
Cc: python-checkins at python.org
Subject: Re: [Python-checkins] r46894 - in python/trunk: Modules/timemodule.c Objects/exceptions.c Objects/fileobject.c

Copying Kristján directly since he may not be subscribed to python-checkins.

On 6/30/06, Thomas Heller <theller at python.net> wrote:
> > +#if defined _MSC_VER && _MSC_VER >= 1400
> > +    /* reset CRT error handling */
> > +    _set_invalid_parameter_handler(prevCrtHandler);
> > +    _CrtSetReportMode(_CRT_ASSERT, prevCrtReportMode);
> > +#endif
> >  }
> ...
>
> These changes to Objects/exceptions.c break the build for Windows AMD64.  Apparently the amd64
> compiler from the Server 2003 SP1 SDK has _MSC_VER >= 1400, but does not know about this new
> error handling.
>
> The compiler identifies itself in this way:
>
> C:\Program Files\Microsoft Platform SDK>cl
> Microsoft (R) C/C++ Optimizing Compiler Version 14.00.40310.41 for AMD64
> Copyright (C) Microsoft Corporation.  All rights reserved.
>
> usage: cl [ option... ] filename... [ /link linkoption... ]
>
> C:\Program Files\Microsoft Platform SDK>
>
>
> Thomas
>
> _______________________________________________
> Python-checkins mailing list
> Python-checkins at python.org
> http://mail.python.org/mailman/listinfo/python-checkins
>