[Python-checkins] r46894 - in python/trunk:Modules/timemodule.c Objects/exceptions.c Objects/fileobject.c

[Kristján V. Jónsson]

Thomas, can you check if testing for the macro __STDC_SECURE_LIB__ in addition to testing the _MSC_VER resolves the problem?  I see no versioning macros for the CRT that we can use for this. 

Kristján

> -----Original Message-----
> From: Tim Peters [mailto:tim.peters at gmail.com]
> Sent: 30. júní 2006 18:38
> To: Kristján V. Jónsson
> Cc: python-checkins at python.org
> Subject: Re: [Python-checkins] r46894 - in python/trunk: 
> Modules/timemodule.c Objects/exceptions.c Objects/fileobject.c
> 
> Copying Kristján directly since he may not be subscribed to 
> python-checkins.
> 
> On 6/30/06, Thomas Heller <theller at python.net> wrote:
> > > +#if defined _MSC_VER && _MSC_VER >= 1400
> > > +    /* reset CRT error handling */
> > > +    _set_invalid_parameter_handler(prevCrtHandler);
> > > +    _CrtSetReportMode(_CRT_ASSERT, prevCrtReportMode); #endif
> > >  }
> > ...
> >
> > These changes to Objects/exceptions.c break the build for Windows 
> > AMD64.  Apparently the amd64 compiler from the Server 2003 
> SP1 SDK has 
> > _MSC_VER >= 1400, but does not know about this new error handling.
> >
> > The compiler identifies itself in this way:
> >
> > C:\Program Files\Microsoft Platform SDK>cl Microsoft (R) C/C++ 
> > Optimizing Compiler Version 14.00.40310.41 for AMD64 Copyright (C) 
> > Microsoft Corporation.  All rights reserved.
> >
> > usage: cl [ option... ] filename... [ /link linkoption... ]
> >
> > C:\Program Files\Microsoft Platform SDK>
> >
> >
> > Thomas
> >
> > _______________________________________________
> > Python-checkins mailing list
> > Python-checkins at python.org
> > http://mail.python.org/mailman/listinfo/python-checkins
> >
> _______________________________________________
> Python-checkins mailing list
> Python-checkins at python.org
> http://mail.python.org/mailman/listinfo/python-checkins
>