[Python-checkins] r47221 - sandbox/trunk/pdb/README.txt sandbox/trunk/pdb/mconnection.py sandbox/trunk/pdb/mpdb.py

[matt.fleming]

Author: matt.fleming
Date: Mon Jul  3 16:18:13 2006
New Revision: 47221

Modified:
   sandbox/trunk/pdb/README.txt
   sandbox/trunk/pdb/mconnection.py
   sandbox/trunk/pdb/mpdb.py
Log:
Remove SO_RESUSEADDR sockopt because it was causing problems with the unit tests on windows and hasn't caused any other problems since it's been removed. Add things to do to README.txt, make MPdb thread-ignorant so that Rocky (mentor) can track thread code changes more easily.

Modified: sandbox/trunk/pdb/README.txt
==============================================================================
--- sandbox/trunk/pdb/README.txt	(original)
+++ sandbox/trunk/pdb/README.txt	Mon Jul  3 16:18:13 2006
@@ -50,4 +50,7 @@
   this currently has _no_ effect. We should at some point be able to switch
   threads and from them on not have to use the 'thread apply <tid> <cmd>' 
   syntax, but just '<cmd>' which would be applied to the current thread.
+* Run command does not pass arguments across a remote connection, i.e.
+      `run 2' does not pass the argument 2 to the script.
+* Allow thread debugging to be turned on with a command line switch.
 

Modified: sandbox/trunk/pdb/mconnection.py
==============================================================================
--- sandbox/trunk/pdb/mconnection.py	(original)
+++ sandbox/trunk/pdb/mconnection.py	Mon Jul  3 16:18:13 2006
@@ -112,7 +112,6 @@
         self.port = int(p)
         if not self.listening:
             self._sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
-            self._sock.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
             try:
                 self._sock.bind((self.host, self.port))
             except socket.error, e:

Modified: sandbox/trunk/pdb/mpdb.py
==============================================================================
--- sandbox/trunk/pdb/mpdb.py	(original)
+++ sandbox/trunk/pdb/mpdb.py	Mon Jul  3 16:18:13 2006
@@ -57,7 +57,7 @@
         self.target = 'local'  # local connections by default
         self.lastcmd = ''
         self.connection = None
-        self.debug_thread = False
+        self._info_cmds.append('target')
 
     def _rebind_input(self, new_input):
         """ This method rebinds the debugger's input to the object specified
@@ -168,11 +168,6 @@
         else:
             pydb.Pdb.do_info(self, arg)
 
-    def help_info(self, *args):
-        """Extends pydb help_info command. """
-        self.subcommand_help('info', getattr(self,'help_info').__doc__,
-                             self._info_cmds, self.info_helper, args[0])
-
     def info_helper(self, cmd, label=False):
         """Extends pydb info_helper() to give info about a single Mpdb
         info extension."""
@@ -183,24 +178,6 @@
         else:
             pydb.Pdb.info_helper(self, cmd)
 
-    def do_set(self, arg):
-        """ Extends pydb do_set() to allow setting thread debugging. """
-        if not arg:
-            pydb.Pdb.do_set(self, arg)
-            return
-
-        args = arg.split()
-        if 'thread'.startswith(args[0]):
-            try:
-                import mthread
-            except ImportError:
-                self.errmsg('Thread debugging is not on')
-                return
-            mthread.init(self.msg, self.errmsg)
-            self.msg('Thread debugging on')
-            self.debug_thread = True
-            return
-
     # Debugger commands
     def do_attach(self, addr):
         """ Attach to a process or file outside of Pdb.