[Python-checkins] r50789 - in python/trunk/Lib: mailbox.py test/test_mailbox.py

["Martin v. Löwis"]

Neal Norwitz wrote:
>>  try:
>> +    if sys.platform == 'os2emx':
>> +        # OS/2 EMX fcntl() not adequate
>> +        raise ImportError
>>      import fcntl
>>  except ImportError:
>>      fcntl = None
> 
> Is there no part of the test that can work on os2emx?

Why do you ask? The ImportError raised will get caught
a few lines later, and fcntl will become None.

>> @@ -1030,6 +1034,9 @@
>>                          if hasattr(os, 'link'):
>>                              os.link(os.path.join(self._path, str(key)),
>>                                      os.path.join(self._path, str(prev + 1)))
>> +                            if sys.platform == 'os2emx':
>> +                                # cannot unlink an open file on OS/2
>> +                                f.close()
>>                              os.unlink(os.path.join(self._path, str(key)))
>>                          else:
>>                              f.close()
> 
> This doesn't seem necessary if we skip the entire test on os2emx.

Ah, but we don't.

Regards,
Martin