[Python-checkins] r50994 - python/trunk/Lib/zipfile.py

[tim.peters]

Author: tim.peters
Date: Mon Jul 31 04:40:23 2006
New Revision: 50994

Modified:
   python/trunk/Lib/zipfile.py
Log:
ZipFile.close():  Killed one of the struct.pack deprecation
warnings on Win32.

Also added an XXX about the line:

                pos3 = self.fp.tell()

`pos3` is never referenced, and I have no idea what the code
intended to do instead.


Modified: python/trunk/Lib/zipfile.py
==============================================================================
--- python/trunk/Lib/zipfile.py	(original)
+++ python/trunk/Lib/zipfile.py	Mon Jul 31 04:40:23 2006
@@ -708,9 +708,10 @@
                         stringEndArchive64Locator, 0, pos2, 1)
                 self.fp.write(zip64locrec)
 
+                # XXX Why is `pos3` computed next?  It's never referenced.
                 pos3 = self.fp.tell()
                 endrec = struct.pack(structEndArchive, stringEndArchive,
-                         0, 0, count, count, pos2 - pos1, 0xffffffff, 0) # -1, 0)
+                            0, 0, count, count, pos2 - pos1, -1, 0)
                 self.fp.write(endrec)
 
             else: