[Python-checkins] r46733 - sandbox/trunk/decimal-c/_decimal.c

Neal Norwitz nnorwitz at gmail.com
Thu Jun 8 06:05:05 CEST 2006


On 6/7/06, mateusz.rukowicz <python-checkins at python.org> wrote:
> Author: mateusz.rukowicz
> Date: Thu Jun  8 01:48:38 2006
> New Revision: 46733
>
> Modified:
>    sandbox/trunk/decimal-c/_decimal.c
> Log:
> Some bugs fixed, draft of new integer representation, from now old will be deleted.

Mateusz,

I didn't do a complete review, however, there were some things I
noticed in this checkin.  If you haven't already, you should read PEP
7 which describes the C coding conventions (style).  It looked like
some whitespace was missing between keywords and parens (such as for(
...).  Another thing I noticed was C99 variable declaration.  Since
Python conforms to an older version of the standard (C89), you should
only declare variables at the beginning of a scope (ie, after { ).

I didn't notice any comments starting with //, but that's also not allowed.

Cheers,
n


More information about the Python-checkins mailing list