[Python-checkins] r46755 - in python/trunk: Misc/NEWS Modules/binascii.c

brett.cannon python-checkins at python.org
Thu Jun 8 18:23:05 CEST 2006


Author: brett.cannon
Date: Thu Jun  8 18:23:04 2006
New Revision: 46755

Modified:
   python/trunk/Misc/NEWS
   python/trunk/Modules/binascii.c
Log:
Make binascii.hexlify() use s# for its arguments instead of t# to actually
match its documentation stating it accepts any read-only buffer.



Modified: python/trunk/Misc/NEWS
==============================================================================
--- python/trunk/Misc/NEWS	(original)
+++ python/trunk/Misc/NEWS	Thu Jun  8 18:23:04 2006
@@ -75,6 +75,9 @@
 Extension Modules
 -----------------
 
+- Change binascii.hexlify to accept a read-only buffer instead of only a char
+  buffer and actually follow its documentation.
+
 - Fixed a potentially invalid memory access of CJKCodecs' shift-jis decoder.
 
 - Patch #1478788 (modified version): The functional extension module has

Modified: python/trunk/Modules/binascii.c
==============================================================================
--- python/trunk/Modules/binascii.c	(original)
+++ python/trunk/Modules/binascii.c	Thu Jun  8 18:23:04 2006
@@ -909,7 +909,7 @@
 	char* retbuf;
 	Py_ssize_t i, j;
 
-	if (!PyArg_ParseTuple(args, "t#:b2a_hex", &argbuf, &arglen))
+	if (!PyArg_ParseTuple(args, "s#:b2a_hex", &argbuf, &arglen))
 		return NULL;
 
 	retval = PyString_FromStringAndSize(NULL, arglen*2);


More information about the Python-checkins mailing list