[Python-checkins] r46996 - python/trunk/Lib/sgmllib.py

[Fredrik Lundh]

fred.drake wrote:

> Modified: python/trunk/Lib/sgmllib.py
> ==============================================================================
> --- python/trunk/Lib/sgmllib.py	(original)
> +++ python/trunk/Lib/sgmllib.py	Sat Jun 17 03:07:54 2006
> @@ -424,11 +424,11 @@
>  
>      def handle_entityref(self, name):
>          """Handle entity references, no need to override."""
> -        replacement = convert_entityref(name)
> +        replacement = self.convert_entityref(name)
>          if replacement is None:
>              self.unknown_entityref(name)
>          else:
> -            self.handle_data(convert_entityref(name))
> +            self.handle_data(self.convert_entityref(name))

why call convert_entityref *twice* for each entity ?  shouldn't this be:

	replacement = convert_entityref(name)
	if replacement is None:
		self.unknown_entityref(name)
	else:
		self.handle_data(replacement)

</F>