[Python-checkins] r42884 - python/trunk/Modules/posixmodule.c

Guido van Rossum guido at python.org
Tue Mar 7 22:05:00 CET 2006

On 3/7/06, "Martin v. Löwis" <martin at v.loewis.de> wrote:
> Guido van Rossum wrote:
> > This suggests that the checked-in code is hopelessly broken. Rolling
> > back is probably the best course of action at this point.
> >
> > What was the motivation anyway?
> The goal was to release the GIL around the API call, see
> python.org/sf/1432525
> I reviewed it, and missed that there is a continue statement in the
> do-while-loop; I find a continue quite strange there. One way to
> fix the code would be to add a label _continue just before the
> new block.

The resulting spaghetti is a bit much. I suggest a better refactoring.

--Guido van Rossum (home page: http://www.python.org/~guido/)

More information about the Python-checkins mailing list