[Python-checkins] r59290 - in python/trunk: Lib/distutils/command/build_ext.py Lib/distutils/cygwinccompiler.py Lib/distutils/msvc9compiler.py Lib/distutils/msvccompiler.py Modules/xxmodule.c

[Georg Brandl]

M.-A. Lemburg schrieb:
> On 2007-12-03 14:47, christian.heimes wrote:
>> Author: christian.heimes
>> Date: Mon Dec  3 14:47:29 2007
>> New Revision: 59290
>> 
>> Added:
>>    python/trunk/Lib/distutils/msvc9compiler.py
>>       - copied, changed from r59283, python/trunk/Lib/distutils/msvccompiler.py
>> Modified:
>>    python/trunk/Lib/distutils/command/build_ext.py
>>    python/trunk/Lib/distutils/cygwinccompiler.py
>>    python/trunk/Lib/distutils/msvccompiler.py
>>    python/trunk/Modules/xxmodule.c
>> Log:
>> Applied my patch #1455 with some extra fixes for VS 2005
>> The new msvc9compiler module supports VS 2005 and VS 2008. I've also fixed build_ext to support PCbuild8 and PCbuild9 and backported my fix for xxmodule.c from py3k. The old code msvccompiler is still in place in case somebody likes to build an extension with VS 2003 or earlier.
>> I've also updated the cygwin compiler module for VS 2005 and VS 2008. It works with VS 2005 but I'm unable to test it with VS 2008. We have to wait for a new version of cygwin.
> 
> ...
> 
> I think you should add a comment to xxmodule.c explaining why you
> defer the initialization of the type object struct until module
> init time. After all, xxmodule.c is an example extension module
> and as such serves a tutorial purpose.

Note how this is already done in xxsubtype.c, with a DEFERRED_ADDRESS macro.

Georg