[Python-checkins] r59387 - python/trunk/PCbuild9/pyproject.vsprops

Christian Heimes lists at cheimes.de
Thu Dec 6 20:19:40 CET 2007


Martin v. Löwis wrote:
> That patch is incorrect. All projects should include pyconfig.h, so
> if some don't, the correction is not to make _CRT_NONSTDC_NO_DEPRECATE
> predefined, but to include it were it's missing.
> 
> (unless there is a good reason for not including it which I fail to see)

The projects make_buildinfo and make_versioninfo don't include
pyconfig.h. The patch silences a warning in make_buildinfo about an
insecure unlink() call.

I could remove _CRT_SECURE_NO_DEPRECATE and _CRT_NONSTDC_NO_DEPRECATE
from pyproject.vsprops and add them to make_buildinfo and
make_versioninfo. But I see no harm in defining them globally.

Christian


More information about the Python-checkins mailing list